[FIX] simplify std::ranges::enable_view overloads #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marehr
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 238 238
Lines 9076 9076
=======================================
Hits 8866 8866
Misses 210 210
Continue to review full report at Codecov.
|
|
I managed to get the weird heuristics out of the standard so none of this code is required anymore. Changes to range-v3 were committed a couple of days ago so you could remove the code after upgrading: |
|
@h-2 Okay, does that change have any impact on our other views? Or do they all inherit from |
|
All our views inherit |
Ah that is good! |
marehr
added a commit
to marehr/seqan3
that referenced
this pull request
Mar 31, 2020
In ericniebler/range-v3#1455 the range-v3 library harmonises range-v3 with C++20's `std::ranges`. One of these changes is the behaviour of `std::ranges::enable_view`. This change is needed for seqan#1680 that will simplify code regarding the `seqan3::gap_decorator`.
marehr
added a commit
to marehr/seqan3
that referenced
this pull request
Apr 5, 2020
In ericniebler/range-v3#1455 the range-v3 library harmonises range-v3 with C++20's `std::ranges`. One of these changes is the behaviour of `std::ranges::enable_view`. This change is needed for seqan#1680 that will simplify code regarding the `seqan3::gap_decorator`.
marehr
added a commit
to marehr/seqan3
that referenced
this pull request
Apr 9, 2020
In ericniebler/range-v3#1455 the range-v3 library harmonises range-v3 with C++20's `std::ranges`. One of these changes is the behaviour of `std::ranges::enable_view`. This change is needed for seqan#1680 that will simplify code regarding the `seqan3::gap_decorator`.
A change in ericniebler/range-v3#1455 simplified the heuristics for std::ranges::enable_view. So the gap_decorator is by default now no view anymore. This PR is also in line with #1678 to remove dependencies of our library in the std headers.
marehr
requested review from
a team and
MitraDarja
and removed request for
a team
rrahn
approved these changes
Apr 20, 2020
MitraDarja
pushed a commit
to MitraDarja/seqan3
that referenced
this pull request
May 5, 2020
In ericniebler/range-v3#1455 the range-v3 library harmonises range-v3 with C++20's `std::ranges`. One of these changes is the behaviour of `std::ranges::enable_view`. This change is needed for seqan#1680 that will simplify code regarding the `seqan3::gap_decorator`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in ericniebler/range-v3#1455 simplified
the heuristics for std::ranges::enable_view. So the gap_decorator is by
default now no view anymore.
This PR is also in line with #1678 to remove dependencies of our library
in the std headers.
old description
I know that this introduces a macro (SEQAN3_STD_RANGES_NAMESPACE), but
this reduces code bloat for a feature that is only used for a single
data structure right now.
This PR is also in line with #1678 to remove dependencies of our library
in the std headers.