Allow resty backend timeout to be configurable #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update config commands to allow getting/setting timeout Update basic config tests to show read/write success Update command tests to show getting/setting timeout Update changelog Signed-off-by: naemono <[email protected]>
echlebek
requested changes
Mar 20, 2020
|
@echlebek these issues should be resolved now with latest commit. Please be aware of etcd-io/bbolt#187 as I was running go 1.14, and ran directly into this when running unit tests. Mass failure. |
Signed-off-by: naemono <[email protected]>
naemono
force-pushed
the
make-timeout-configurable
branch
from
48cb398 to
f9a39cf
Compare
echlebek
approved these changes
Mar 27, 2020
|
To be merged following the 5.19.0 release. |
echlebek
pushed a commit
that referenced
this pull request
Mar 27, 2020
* Update config commands to allow getting/setting timeout * Update basic config tests to show read/write success * Update command tests to show getting/setting timeout * Update changelog Signed-off-by: naemono <[email protected]>
echlebek
pushed a commit
that referenced
this pull request
Mar 27, 2020
* Update config commands to allow getting/setting timeout * Update basic config tests to show read/write success * Update command tests to show getting/setting timeout * Update changelog Signed-off-by: naemono <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Allow resty backend timeout to be configurable
Why is this change necessary?
Closes #3635
The timeout isn't configurable, as gets triggered on highly used installations.
Does your change need a Changelog entry?
Yes, the changelog was updated in the "Unreleased" section
Have you reviewed and updated the documentation for this change? Is new documentation required?
Documentation likely needs to be updated about this change. Could someone point me to the right location?
How did you verify this change?
Build sensuctl binary locally, and verified the setting was adjusted, and persisted in configuration file
Is this change a patch?
No