Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Allowing Resty HTTP Timeout to be configurable #3635

Closed
naemono opened this issue Mar 19, 2020 · 4 comments · Fixed by #3637
Closed

[Proposal] Allowing Resty HTTP Timeout to be configurable #3635

naemono opened this issue Mar 19, 2020 · 4 comments · Fixed by #3637

Comments

@naemono
Copy link
Contributor

naemono commented Mar 19, 2020

https://github.com/sensu/sensu-go/blob/master/cli/client/client.go#L43

The question/proposal is centered around the above code ^^. Would a PR be acceptable to

  • allow that timeout to be configurable at all?
  • allow that timeout to be configurable from the cli?
  • allow that timeout configurable item to be persisted in the configuration file

Possible Implementation

Draft PR here naemono#1

Context

In heavily used sensu-go installations, sometimes 15 seconds isn't quite enough time to get a response.

@echlebek
Copy link
Contributor

It looks reasonable to me, I'll bring it to the team and let you know!

@echlebek
Copy link
Contributor

@naemono we're supportive of this change. Please file a PR whenever you are ready. Thanks! 👍 🎉

@naemono
Copy link
Contributor Author

naemono commented Mar 20, 2020

thanks @echlebek . Should this just be closed now? #3637 opened.

@echlebek
Copy link
Contributor

We can close it once #3637 is merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants