-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add @zk-kit/artifacts
#788
Conversation
5a7614e
to
239a90a
Compare
setting back to draft although the checks pass. there is a remaining bug related to jest picking the browser exports instead of node. I am not sure why (especially because jest's default But it causes the circuits and contracts tests to fail locally (and they are skipped in the ci). |
This privacy-scaling-explorations/snark-artifacts#57 should fix it. I tested it locally. |
Yes, that new config works. Then I think this: https://github.com/semaphore-protocol/semaphore/pull/788/files#diff-860bd1f15d1e0bafcfc6f62560524f588e6d6bf56d4ab1b0f6f8146461558730R16 can be removed. |
Thanks @cedoor @vplasencia |
Description
privacy-scaling-explorations/snark-artifacts#45 and privacy-scaling-explorations/zk-kit#288 moved the functions to download the snark artifacts out of
@zk-kit/utils
and into a dedicated@zk-kit/artifacts
package.This PR adds and uses this package to download the artifacts in the
@semaphore-protocol/proof
package.Other information
New release and bumping of
@zk-kit/utils
here is not necessary. Because the feature removed from it is now brought by@zk-kit/artifacts
and this package is now added as a dep in the only semaphore package that uses it:@semaphore-protocol/proof
.Nonetheless once the new release of
@zk-kit/utils
is released (see privacy-scaling-explorations/zk-kit#290) , we should bump it in@semaphore-protocol/proof
too (because now similar functions could theoretically imported from 2 different packages...): captured in #789Checklist
I have made corresponding changes to the documentationNAyarn format
andyarn lint
without getting any errorsI have added tests that prove my fix is effective or that my feature worksNA