refactor(utils): remove @zk-kit/utils/snark-artifacts
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move it into `@zk-kit/artifacts` https://github.com/privacy-scaling-explorations/snark-artifacts re #287
sripwoud
added
the
refactoring ♻️
sripwoud
force-pushed
the
refactor/snark-artifacts
branch
from
9c9329d to
76b739d
Compare
sripwoud
commented
May 19, 2024
| @@ -12,6 +12,7 @@ const projects: any = fs | |||
| rootDir: `packages/${name}`, | |||
| displayName: name, | |||
| moduleNameMapper: { | |||
| "@zk-kit/artifacts": ["<rootDir>/../../node_modules/@zk-kit/artifacts/dist/index.node.cjs"], | |||
There was a problem hiding this comment.
as @zk-kit/artifacts is out of the monorepo packages, we must not override the corresponding entry it in the moduleNameMapper object. Is there a better way?
sripwoud
force-pushed
the
refactor/snark-artifacts
branch
from
5af9246 to
3a1b732
Compare
|
capture: release new version of |
7 tasks
vplasencia
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snark-artifactsmodule of@zk-kit/utils: replace it by@zk-kit/artifactsre #287
Description
Related Issue(s)
Other information
Checklist
yarn stylewithout getting any errors