Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add sectors numbers to ordinary messages, and bigger separators #6

Closed
febs opened this issue May 15, 2024 · 10 comments

Comments

@febs
Copy link

febs commented May 15, 2024

The bot only mentions the Sectors Wilaya and number only when applying the "show all" command, or at least that was the only case where I have seen those used.

Normally the sectors are only referred to with their name.
I think that it would be very helpful to be able to also see their Sector "code" alonsgide with their name, maybe even with a colored text.
This could be optional eventually.

That's my suggestion and feature request.
Secondarily, I would think that adding more newlines or extra --------------------------------- could help readability. Especially when the bot does loads of stuff, I find it easy to miss something along the way.

Thank you for the bot nevertheless,

@sellmerfud
Copy link
Owner

I'll look into displaying the sector id's along with the name in the log output.

I have resisted adding colored text, because the Windows command shell does not support ANSI escape codes for color.
As far as I know there is no other way to support color on Windows. I do not have a computer running Windows so it is not something that I can easily test.

I have thought about adding a "Press return to continue" prompt at certain points during the output of the Bot's turn so that you do not miss what is going on. I did this with the "Fire in the Lake" program and I think it works well.

Thanks for the suggestions.

@febs
Copy link
Author

febs commented May 16, 2024

A prompt after each step would also work very well.

Thank you,

@sellmerfud
Copy link
Owner

sellmerfud commented May 16, 2024 via email

@febs
Copy link
Author

febs commented May 16, 2024

It is SO much better now! Thank you very much.

@febs
Copy link
Author

febs commented May 20, 2024

I forked your project to fiddle with this and I got a result I'm pretty happy with, despite being very rough. It is working on Windows, maybe this might be of interest for you.

Here's how it looks:
image

Regards,

@sellmerfud
Copy link
Owner

So the windows console does support color! I didn't know.

@febs
Copy link
Author

febs commented May 20, 2024

Well admittedly that window is the VS code terminal. I am unable to build on Windows so I am running the bot with "sbt run".

@febs
Copy link
Author

febs commented May 20, 2024

I confirm it is also working in the ordinary dull windows terminal:

image

@sellmerfud
Copy link
Owner

I added changes similar to what you did to support color.
The colors are also saved in the save files so that you get color when using the history command.

@febs
Copy link
Author

febs commented May 21, 2024

This is amazing! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants