Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#306 Fixed Options Buttons Don't Work On 2+ Pages Of Table. #307

Merged
merged 1 commit into from
Jan 2, 2021

Conversation

criske
Copy link
Contributor

@criske criske commented Jan 2, 2021

Fixes #306

@charlesmike
Copy link

@criske thank you for your Pull Request. I'll assign someone to review it soon.

@criske
Copy link
Contributor Author

criske commented Jan 2, 2021

@amihaiemil There is a visual bug still: when mark a contract for removal in Projects' contract tab and we're on another page, the whole table is reloaded from page 1 and losing the current page. markContractForRemoval in Contributor dashboard is doing this correctly though.
This bug should be covered by #285

--
btw no bounty needed for this pr.

@charlesmike
Copy link

@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is 2021-01-05T14:38:48.784120.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@amihaiemil
Copy link
Member

@criske thanks, looks good!

@amihaiemil amihaiemil merged commit 16f9b8f into self-xdsd:master Jan 2, 2021
@charlesmike
Copy link

@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

@criske criske deleted the issue306 branch January 6, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Options Buttons Don't Work On 2nd Page Of Table
3 participants