Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options Buttons Don't Work On 2nd Page Of Table #306

Closed
amihaiemil opened this issue Jan 2, 2021 · 4 comments · Fixed by #307
Closed

Options Buttons Don't Work On 2nd Page Of Table #306

amihaiemil opened this issue Jan 2, 2021 · 4 comments · Fixed by #307
Labels
120min bug Something isn't working

Comments

@amihaiemil
Copy link
Member

On the Contributor Dashboard page, the Options buttons (Contract Agenda, Mark For Removal) are not working on the second and later pages. This might also be a problem in other tables. As far as I can tell, it's related to the new table loading approach.

Screenshot 2021-01-02 at 11 09 24

The problem is most likely that the event listeners are only appended to the elements visible on the first page of the table.

@amihaiemil amihaiemil added bug Something isn't working 120min labels Jan 2, 2021
@charlesmike
Copy link

@criske this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2021-01-12T11:11:39.750280.

Estimation here is 120 minutes, that's how much you will be paid.

Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.

If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.

If you don't have time or simply don't want to work on this, you can always resign.

@charlesmike
Copy link

@amihaiemil please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.

@criske
Copy link
Contributor

criske commented Jan 2, 2021

@amihaiemil yep, I was about to open an issue about this too. I played a bit with datatables to find a way to edit cells (maybe we can use it to update contracts from table directly). Anyway the fix is to register listeners on draw callback. I'll open a pr asap.

criske added a commit to criske/self-web that referenced this issue Jan 2, 2021
amihaiemil added a commit that referenced this issue Jan 2, 2021
#306 Fixed Options Buttons Don't Work On 2+ Pages Of Table.
@charlesmike
Copy link

@criske thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
120min bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants