Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#253 Contributor stripe dashboard opens in a new tab. #281

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

criske
Copy link
Contributor

@criske criske commented Dec 19, 2020

  • also added one puzzle for wallet activation and one for contracts table optimization.

fixes #253

- also added one puzzle for wallet activation and one for contracts table optimization.
@charlesmike
Copy link

@criske thank you for your Pull Request. I'll assign someone to review it soon.

@criske
Copy link
Contributor Author

criske commented Dec 19, 2020

no bounty

@charlesmike
Copy link

@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is 2020-12-22T13:16:52.246060.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

Copy link
Member

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@criske just one question

@@ -139,7 +139,8 @@ function getProjectWallets() {
* @param owner Owner of the repo/project.
* @param name Name of the repo.
* @param type Type of the wallet (fake or stripe).
* @todo #195#60min On frontend, enable wallet activation. Right now `activateWallet()` function is not used.
* @todo #253:30min On frontend, enable wallet activation.
* Right now `activateWallet()` function is not used ('activate' button doesn't work).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@criske I don't think we need this TODO, wallet activation works fine since a month ago I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil on my end is not working
Self XDSD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@criske the button is inactive because the Limit is 0. Try setting up a Limit, then it should work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@criske and also at least a Payment Method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it works now.

- also added puzzle for contracts table optimization.
@charlesmike
Copy link

@amihaiemil Don't forget to close this ticket before the deadline (2020-12-22T13:16:52). You are past the first half of the allowed period.

@charlesmike
Copy link

@amihaiemil Looks like you've missed the task deadline (2020-12-22T13:16:52). You are now resigned from this task.

Please stop working on it, you will not be paid. I will assign it to someone else soon.

@charlesmike
Copy link

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@amihaiemil
Copy link
Member

@criske thanks!

@amihaiemil amihaiemil merged commit fe93595 into self-xdsd:master Dec 23, 2020
@criske criske deleted the issue253 branch December 23, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When navigating back from the "Stripe Dashboard" page, user should be redirected to the "Payout Methods" page
3 participants