-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#253 Contributor stripe dashboard opens in a new tab. #281
Conversation
- also added one puzzle for wallet activation and one for contracts table optimization.
@criske thank you for your Pull Request. I'll assign someone to review it soon. |
no bounty |
@amihaiemil please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@criske just one question
@@ -139,7 +139,8 @@ function getProjectWallets() { | |||
* @param owner Owner of the repo/project. | |||
* @param name Name of the repo. | |||
* @param type Type of the wallet (fake or stripe). | |||
* @todo #195#60min On frontend, enable wallet activation. Right now `activateWallet()` function is not used. | |||
* @todo #253:30min On frontend, enable wallet activation. | |||
* Right now `activateWallet()` function is not used ('activate' button doesn't work). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@criske I don't think we need this TODO, wallet activation works fine since a month ago I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil on my end is not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@criske the button is inactive because the Limit is 0. Try setting up a Limit, then it should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@criske and also at least a Payment Method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, it works now.
- also added puzzle for contracts table optimization.
@amihaiemil Don't forget to close this ticket before the deadline (2020-12-22T13:16:52). You are past the first half of the allowed period. |
@amihaiemil Looks like you've missed the task deadline (2020-12-22T13:16:52). You are now resigned from this task. Please stop working on it, you will not be paid. I will assign it to someone else soon. |
@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role Please, make sure there is at least one available contributor with the required role and the project can afford to pay them. |
@criske thanks! |
fixes #253