Skip to content

Commit

Permalink
Merge pull request #281 from criske/issue253
Browse files Browse the repository at this point in the history
#253 Contributor stripe dashboard opens in a new tab.
  • Loading branch information
amihaiemil authored Dec 23, 2020
2 parents a23ce53 + bd9bdd4 commit fe93595
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
3 changes: 3 additions & 0 deletions src/main/resources/public/js/getAndAddContracts.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
* but this a good practice since "$" is not "reserved" to jQuery.
* Now "$" is just a function argument name and not the jQuery
* alias anymore. It could named "foo" fo ex, thus making a call like foo("#contracts") valid.
* @todo #253:60min On frontend, in Contracts tab, after adding a new contract, we should add the new
* contract to contract table, instead of updating table by re-fetching all contracts again.
* Same logic should be applied to "markContractForRemove" and "restoreContract".
*/
(function getAndAddContracts($, contractsService, usersService, confirmDialog){

Expand Down
1 change: 0 additions & 1 deletion src/main/resources/public/js/wallets.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ function getProjectWallets() {
* @param owner Owner of the repo/project.
* @param name Name of the repo.
* @param type Type of the wallet (fake or stripe).
* @todo #195#60min On frontend, enable wallet activation. Right now `activateWallet()` function is not used.
*/
function activateWallet(owner, name, type) {
if(type == 'stripe') {
Expand Down
4 changes: 3 additions & 1 deletion src/main/resources/templates/contributor.html
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,9 @@ <h4>Account ID: <span id="accountId"></span></h4>
data: form.serialize(),
success: function (payoutMethod) {
console.log("Opening SCA Dashboard page: " + payoutMethod.stripeLoginLink)
window.location.replace(payoutMethod.stripeLoginLink);
$("<a href=" + payoutMethod.stripeLoginLink + " target='_blank'></a>")[0].click();
$("#stripeDashboardButton").removeClass("disabled");
$("#loadingStripeDashboardForm").hide();
},
error: function(jqXHR, error, errorThrown) {
$("#stripeDashboardButton").removeClass("disabled");
Expand Down

0 comments on commit fe93595

Please sign in to comment.