Loopback: fix & documentation #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guedou
force-pushed
the
loopback
branch
2 times, most recently
from
eaec7fa to
bbbb189
Compare
gpotter2
previously approved these changes
Sep 8, 2021
There was a problem hiding this comment.
LGTM. You could potentially add this as a comment to document this: https://github.com/the-tcpdump-group/libpcap/blob/f98637ad7f086a34c4027339c9639ae1ef842df3/gencode.c#L3333-L3354
gpotter2
approved these changes
Sep 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #3363 +/- ##
==========================================
+ Coverage 85.16% 86.00% +0.84%
==========================================
Files 274 274
Lines 56656 57805 +1149
==========================================
+ Hits 48250 49717 +1467
+ Misses 8406 8088 -318
|
|
Ready to be merged. |
|
Just FYI, you're branching on secdev/scapy directly. I usually avoid doing that :) |
bzalkilani
pushed a commit
to bzalkilani/scapy
that referenced
this pull request
Jun 12, 2022
* Use the correct type value to inject IPv6 packets on the loopback interface * Documenting loopback packets injection * Document AF_INET6 specificity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes injecting IPv6 packets to the Windows loopback interface (#3357), and improves the documentation.