Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation regex for @requires annotation #3460

Merged
merged 3 commits into from
Jan 3, 2019
Merged

Fix validation regex for @requires annotation #3460

merged 3 commits into from
Jan 3, 2019

Conversation

epdenouden
Copy link
Contributor

@epdenouden epdenouden commented Jan 2, 2019

Fixes #3459

The regex used for parsing the @require annotation would put any trailing digits of the value into the version field when there wasn't an operator. This caused trailing digits on function and extension names to be clipped.

Changes

  • regex fixed
  • add test for @requires function|extension someNameWithDigits123

@epdenouden epdenouden changed the title Fix bug #3459 caused by validation regex for @requires-annotation Fix validation regex for @requires-annotation Jan 2, 2019
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #3460 into 7.5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                7.5    #3460   +/-   ##
=========================================
  Coverage     83.42%   83.42%           
  Complexity     3619     3619           
=========================================
  Files           143      143           
  Lines          9635     9635           
=========================================
  Hits           8038     8038           
  Misses         1597     1597
Impacted Files Coverage Δ Complexity Δ
src/Util/Test.php 93.71% <ø> (ø) 217 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9551b60...f65fd77. Read the comment docs.

@epdenouden epdenouden changed the title Fix validation regex for @requires-annotation Fix validation regex for @requires annotation Jan 2, 2019
@sebastianbergmann sebastianbergmann merged commit b477edf into sebastianbergmann:7.5 Jan 3, 2019
@epdenouden epdenouden deleted the issue-3459-requires-annotation-without-operator branch January 3, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants