-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@requires function swallows digits at the end of function name #3459
Comments
@MaxSem Thanks for taking the time to submit the issue! I have reproduced it in the self-test collection and... fireworks! A solid start to 2019, I say. Will submit a pull request with a fix. I will also check whether the other |
Aha, seems the regex eats the trailing digit as a part of a version requirement. I'll have to do some exploring to make sure a fix for this doesn't break a bunch of other use cases. |
Due to sebastianbergmann/phpunit#3459 it was looking for a wrong function name and was skipping the test even when PHP support was present. Change-Id: I2508f192a76275286e95bd6a06e4628d98b11737
@MaxSem PHPUnit 6.5.14 has just been released and I noticed the Mediawiki Again thanks for reporting the bug, it has been fixed in v7 and v8 too :) |
If a required function name ends with a digit, PHPUnit misses the digit(s).
Example:
Current behavior:
Expected behavior: test is not skipped because
hash_pbkdf2()
is present.The text was updated successfully, but these errors were encountered: