Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add body font-size changer #962

Closed
wants to merge 1 commit into from

Conversation

LordSimal
Copy link

Redo #961 with 9.2 as a base branch

@LordSimal
Copy link
Author

I gotta say: Making those tests work is quite cumbersome...

@sebastianbergmann
Copy link
Owner

I will look into the preg_match(): Compilation failed: regular expression is too large issue.

@sebastianbergmann
Copy link
Owner

I do not have a solution for the preg_match() issue yet, but this is needed:

diff --git a/tests/_files/Report/HTML/PHP81AndUp/CoverageForClassWithAnonymousFunction/index.html b/tests/_files/Report/HTML/PHP81AndUp/CoverageForClassWithAnonymousFunction/index.html
index 6651a25..abd2702 100644
--- a/tests/_files/Report/HTML/PHP81AndUp/CoverageForClassWithAnonymousFunction/index.html
+++ b/tests/_files/Report/HTML/PHP81AndUp/CoverageForClassWithAnonymousFunction/index.html
@@ -122,6 +122,5 @@
   </div>
   <script src="_js/jquery.min.js" type="text/javascript"></script>
   <script src="_js/font-size-changer.js" type="text/javascript"></script>
-  <script src="_js/font-size-changer.js" type="text/javascript"></script>
  </body>
 </html>

@LordSimal
Copy link
Author

Right, i missed that one

@LordSimal
Copy link
Author

just wanted to ask if you found a solution for the preg_match() error 😄

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it as I think that using the browser's native zoom functionality is a better fit.

@LordSimal LordSimal deleted the 9.2-font-size branch December 13, 2022 07:56
@JoSSte
Copy link

JoSSte commented Dec 19, 2022

@sebastianbergmann having to zoom every single page you visit, while analyzing logs is actually quite tedious. I came here so report this issue, found #961 and was pleased. Followed this thread and am dissapointed. Could it be possible to change the default size to a unit based off the window size like vw or vh instead of em which is based off of the screen size?
https://www.w3.org/Style/Examples/007/units.en.html

@sebastianbergmann
Copy link
Owner

As I wrote in #960 (comment)

I am not a frontend developer, sorry.

If you think that using vw or vh would fix this: great. Send a pull request so that others can provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants