add body font-size changer #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s names and function names
|
Thanks! Can you send this against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #960
This adds 4 Buttons at the top right of the coverage page to let the user choose which kind of font-size they prefer.
Currently there is
0.75em)1em) which is default Browser behavior (16px)1.5em)2em)The way how this is saved across requests is done via localstorage and therefore currently requies JS to be executed.
This also introduces a small CLS jump. This could be mitigated via implementing it via cookies and adding the correct data-attribute to the body in PHP beforehand.