Use consistent color in first column of HTML Report #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sebastianbergmann#926. The first column in the HTML Report will now be colored by the "Lines" coverage level regardless of view (Directory vs. File) or item type (Directory, File, Class, or Method). While this is somewhat a matter of preference, I think the following arguments support this change: * Prior to sebastianbergmann#900, the first column was always colored the same as the second column. This change restores that pattern since the second column is always "Lines" as of sebastianbergmann#900. * In the File view, the first column for Class and Method items were colored by "Class" and "Method" coverage respectively. This meant that they were only ever 0/1 or 1/1 (red or green). By switching to "Lines" coverage for both, the coloring can be more granular.
Codecov Report
@@ Coverage Diff @@
## 9.2 #927 +/- ##
=========================================
Coverage 83.66% 83.66%
Complexity 1161 1161
=========================================
Files 59 59
Lines 3415 3415
=========================================
Hits 2857 2857
Misses 558 558 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you, @hemberger! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #926.
The first column in the HTML Report will now be colored by the "Lines"
coverage level regardless of view (Directory vs. File) or item type
(Directory, File, Class, or Method).
While this is somewhat a matter of preference, I think the following
arguments support this change:
Prior to Synchronize column ordering between Html\Renderers #900, the first column was always colored the same as the
second column. This change restores that pattern since the second
column is always "Lines" as of Synchronize column ordering between Html\Renderers #900.
In the File view, the first column for Class and Method items were
colored by "Class" and "Method" coverage respectively. This meant
that they were only ever 0/1 or 1/1 (red or green). By switching to
"Lines" coverage for both, the coloring can be more granular.
Previous behavior:
New behavior:
