Synchronize column ordering between Html\Renderers #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sebastianbergmann#827. The column ordering was reversed in the File renderer compared to the Directory renderer. This made it a bit confusing when jumping between directory and file reports. The File renderer now uses the same column ordering as the Directory renderer.
Codecov Report
@@ Coverage Diff @@
## 9.2 #900 +/- ##
============================================
- Coverage 83.70% 83.37% -0.33%
+ Complexity 1129 1127 -2
============================================
Files 59 59
Lines 3548 3237 -311
============================================
- Hits 2970 2699 -271
+ Misses 578 538 -40
Continue to review full report at Codecov.
|
hemberger
added a commit
to hemberger/php-code-coverage
that referenced
this pull request
Aug 19, 2022
Fixes sebastianbergmann#926. The first column in the HTML Report will now be colored by the "Lines" coverage level regardless of view (Directory vs. File) or item type (Directory, File, Class, or Method). While this is somewhat a matter of preference, I think the following arguments support this change: * Prior to sebastianbergmann#900, the first column was always colored the same as the second column. This change restores that pattern since the second column is always "Lines" as of sebastianbergmann#900. * In the File view, the first column for Class and Method items were colored by "Class" and "Method" coverage respectively. This meant that they were only ever 0/1 or 1/1 (red or green). By switching to "Lines" coverage for both, the coloring can be more granular.
sebastianbergmann
pushed a commit
that referenced
this pull request
Aug 20, 2022
Fixes #926. The first column in the HTML Report will now be colored by the "Lines" coverage level regardless of view (Directory vs. File) or item type (Directory, File, Class, or Method). While this is somewhat a matter of preference, I think the following arguments support this change: * Prior to #900, the first column was always colored the same as the second column. This change restores that pattern since the second column is always "Lines" as of #900. * In the File view, the first column for Class and Method items were colored by "Class" and "Method" coverage respectively. This meant that they were only ever 0/1 or 1/1 (red or green). By switching to "Lines" coverage for both, the coloring can be more granular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #827.
The column ordering was reversed in the File renderer compared to the
Directory renderer. This made it a bit confusing when jumping between
directory and file reports.
The File renderer now uses the same column ordering as the Directory
renderer.
Example File report summary from v9.2.11:
Example File report summary from this PR:
