-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: File inputs not able to be a single file #190
Conversation
madhavmk
commented
Nov 24, 2023
•
edited
Loading
edited
- gather_files() returns dictionary of type Dict[str, List[str]]. all_files_dict dictionary values are now list of strings, even in case of single file value.
- load_sound_speed() and load_deletions() modified to concatenate dataframes if multiple file input provided.
- Unittests modified to support above changes.
- tests/data/2022/NCL1/ctd/CTD_NCL_Ch_Mi, tests/data/2022/NCL2/ctd/CTD_NCL_Ch_Mi, tests/data/2022/NCL1/deletns.dat, tests/data/2022/NCL2/deletns.dat test files modified/added.
- Fixes File inputs not able to be a single file #184
- Ensures that "sound_speed", "travel_times", "gps_solution", "deletions" values can be a single-file value rather than a multi-file glob.
- Now "sound_speed" and "deletions" accept multi-file values as input.
…_files_dict dictionary values are now list of strings, even in case of single file value. * load_sound_speed() and load_deletions() modified to concatenate dataframes if multiple file input provided. * Unittests modified to support above changes. * tests/data/2022/NCL1/ctd/CTD_NCL_Ch_Mi, tests/data/2022/NCL2/ctd/CTD_NCL_Ch_Mi, tests/data/2022/NCL1/deletns.dat, tests/data/2022/NCL2/deletns.dat test files modified/added. *
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 50.86% 50.98% +0.11%
==========================================
Files 16 16
Lines 863 865 +2
==========================================
+ Hits 439 441 +2
Misses 424 424 ☔ View full report in Codecov by Sentry. |
Hello @johnbdesanto,
I have performed tests with the sample test data. It would be really helpful if you could verify that this is also working with actual data and config on your system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes @madhavmk 😄 However, the new, duplicated test data created are not in the right structure.
NCL1
is the site ID that the data is captured from, therefor havingNCL2
doesn't make sense and can be a source of confusion.- There are docstrings in code that doesn't make sense, please see my inline comment above.
If you can, please don't modify the test data directly, but rather you can do so on the fly.
* Revert pytest config.yaml to original configuration
Thank you for reviewing the PR @lsetiawan . |