-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File inputs not able to be a single file #184
Comments
The key function that creates the listing of path strings when glob path is given The will become: {
"sound_speed": str,
"travel_times": List[str],
"gps_solution": List[str],
"deletions": str,
} As you notice in above dictionary, I've matched the types to the expected input type for each loader function. Currently only "sound_speed" and "deletions" are expected to have single file. |
Proposed SolutionA solution to the above for this issue should be that every loader inputs should be a Sample config input input_files:
sound_speed:
path: ./tests/data/2022/NCL1/ctd/CTD_NCL1_Ch_Mi
travel_times:
path: ./tests/data/2022/NCL1/208/WG_20220727/pxp_tt
gps_solution:
path: ./tests/data/2022/NCL1/208/posfilter/POS_FREED_TRANS_TWTT
deletions:
path: ./tests/data/2022/NCL1/deletns.dat The above inputs should output the following for the {
"sound_speed": ["absolute/path/to/tests/data/2022/NCL1/ctd/CTD_NCL1_Ch_Mi"],
"travel_times": ["absolute/path/to/tests/data/2022/NCL1/208/WG_20220727/pxp_tt"],
"gps_solution": ["absolute/path/to/tests/data/2022/NCL1/208/posfilter/POS_FREED_TRANS_TWTT"],
"deletions": ["absolute/path/to/tests/data/2022/NCL1/deletns.dat"],
} The following functions should not fail when their respective list of path is given
|
Overview
John has discovered in #175 that when input files is set to be a single file rather than a glob path, it doesn't work. For example, if a user set a single file for pxp_tt like:
this will fail!
The text was updated successfully, but these errors were encountered: