Various minor fixes #258
Merged
Various minor fixes #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed.by.timestamps` If no custom event timestamps are available in the ProjectData object, an error is thrown in `split.data.time.based.by.timestamps`, to avoid passing `NULL` to the called splitting functions. Signed-off-by: Thomas Bock <[email protected]>
To avoid running into various errors when calculating scale-freeness for an empty network, check if the network is empty before calculating scale-freeness and return `NA` right away if the network is empty. Signed-off-by: Thomas Bock <[email protected]>
In commit e72eff8, the function `get.expanded.adjacency.matrices` has been refactored. Unfortunately, the author names have only be extracted from each network individually instead of globally over all networks. This way, the functionality of the function has been changed inadvertently. With this commit, we follow-up on this and restore the previous behavior. As `get.author.names.from.networks(networks)` now always returns a list, accessing the first element is necessary (although this was not necessary in previous implementations). Moreover, this commit also fixes a wrong test with respect to get.expanded.adjacency.matrices`. Signed-off-by: Thomas Bock <[email protected]>
To stay consistent with the naming scheme of our test files, rename 'test-util-networks-misc.R' to 'test-networks-misc.R'. Signed-off-by: Thomas Bock <[email protected]>
In various of our source-code files, our coding conventions
have been violated. With this commit, we fix the most obvious violations:
- semicolon at the end of a statement
- missing space between "if" and the subsequent "("
- superfluous space between "return" and "("
- inconsistent indentation
Signed-off-by: Thomas Bock <[email protected]>
The bug in igraph's `disjoint_union` regarding unintended type conversions is still present in the current igraph version 2.0.3. Therefore, we update the corresponding comment in our source code. Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
bockthom
force-pushed
the
thomas-updates
branch
from
1a2c0a9 to
279b7fc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
showcase.Rwith respect to my changes.dev.Description
This PR contains a few minor fixes in various parts of coronet (i.e., add some checks for corner cases) and restores the intended behavior of
get.expanded.adjacency.matrices, which has been broken recently.Changelog
split.data.time.based.by.timestampsThrow an error if no custom event timestamps are available in the ProjectData object, to avoid passing
NULLto the afterwards called splitting functions.To avoid running into various errors, check if the network is empty before calculating scale-freeness and return
NAright away if the network is empty.get.expanded.adjacency.matricesIn commit e72eff8, the function
get.expanded.adjacency.matriceshas been refactored. Unfortunately, the author names have only be extracted from each network individually instead of globally over all networks. This way, the "expansion" functionality of the function has been changed inadvertently. Thus, we need to restore the previous behavior.