Skip to content

Commit

Permalink
Update comment on igraph's disjoint_union
Browse files Browse the repository at this point in the history
The bug in igraph's `disjoint_union` regarding unintended type
conversions is still present in the current igraph version 2.0.3.
Therefore, we update the corresponding comment in our source code.

Signed-off-by: Thomas Bock <[email protected]>
  • Loading branch information
bockthom committed Apr 12, 2024
1 parent 8b41f10 commit da4c71b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions util-networks.R
Original file line number Diff line number Diff line change
Expand Up @@ -1047,9 +1047,9 @@ NetworkBuilder = R6::R6Class("NetworkBuilder",
## 1) merge the existing networks
u = igraph::disjoint_union(authors.net, artifacts.net)

## As there is a bug in 'igraph::disjoint_union' in igraph versions 1.4.0, 1.4.1, and 1.4.2
## (see https://github.com/igraph/rigraph/issues/761), we need to adjust the type of the date attribute
## of the outcome of 'igraph::disjoint_union'.
## As there is a bug in 'igraph::disjoint_union' in igraph from its version 1.4.0 on, which is still
## present, at least, until its version 2.0.3 (see https://github.com/igraph/rigraph/issues/761), we need
## to adjust the type of the date attribute of the outcome of 'igraph::disjoint_union'.
## Note: The following temporary fix only considers the 'date' attribute. However, this problem could also
## affect several other attributes, whose classes are not adjusted in our temporary fix.
## The following code block should be redundant as soon as igraph has fixed their bug.
Expand Down

0 comments on commit da4c71b

Please sign in to comment.