Version 3.1.1 #108
Merged
Version 3.1.1 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of the introduction of the 'NetworkBuilder' class in version v3.0, the 'NetworkConf' object is not any more held by the 'ProjectData' objects, but by the 'NetworkBuilder' object. According to that, the README.md file is updated now. Signed-off-by: Thomas Bock <[email protected]>
This is a follow-up commit for d4b8ff9, which introduced the 'remove.isolates' parameter already to the function 'split.network.time.based'. Now, we also add this option to the functions 'split.networks.time.based' and also to 'split.network.time.based.by.ranges'. Signed-off-by: Thomas Bock <[email protected]>
When adding already exisiting author-role classifications using the 'add.vertex.attribute.author.role' function, we do not need the project data, and also no aggregation level is used. Hence, the corresponding parameters are removed now. As no data has to be split any more, this also increases the performance of this function drastically. This addresses #102 and fixes Issue 1 therein. Signed-off-by: Thomas Bock <[email protected]>
When the time difference between 'start' and 'end' is smaller than 'time.period', the 'construct.*.ranges' functions produce wrong results. This commit fixes that and updates the documentation of those functions. This addresses #103. Signed-off-by: Thomas Bock <[email protected]>
Add a test for constructing ranges when the difference between start and end is smaller than the time.period. This tests the corner case addressed in commit 975ae4d. Together with 975ae4d, this fixes #103. Signed-off-by: Thomas Bock <[email protected]>
Add a new function 'match.arg.or.default' for argument verification which is able to take a specified default value. As the 'match.arg' function of R-base takes the first element of the choices vector as default, we introduce a new function to allow specifing another default value. If no default value is specified, the function 'match.arg.or.default' just calls the 'match.arg' function of R-base. Signed-off-by: Thomas Bock <[email protected]>
Use the newly introduced 'match.arg.or.default' function to verify the 'aggregation.level' and arguments used for adding vertex attributes und set their defaults. The new default values for 'aggergation.level' are 'range', except for the computation of 'first.occurrence' and 'first.activity' where the defaults are 'complete'. In addition, adapt the test for 'add.vertex.attribute.artifact.first.occurrence' accordingly and test for all aggregation levels there. This addresses issue 3 in #102. Add a TODO to the 'first activity' function to maybe later support getting first activty over all data.sources. Signed-off-by: Thomas Bock <[email protected]>
Adapt the tests for the vertex attributes 'artifact.editor.count' and 'artifact.change.count' to test all possible aggregation levels. Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
If all the ranges given to 'split.data.time.based.by.ranges' are identical, just split the data once and clone the resulting range data objects. This addresses issue 2 in #102. Signed-off-by: Thomas Bock <[email protected]>
Update README.md and CONTRIBUTING.md regarding branching and tagging: From now on, we only provide fixes-branches containing backported bugfixes for the last minor version of the second last major version. We will do this only in some special cases. All the other bugfixes conerning the current major version will end up in a new bugfix version related to the current minor version. Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Introduce some minor fixes for the changes in PR #105: rewording, spaces, empty lines, outdated lines. Signed-off-by: Thomas Bock <[email protected]>
Some fixes to README, range construction, vertex attributes, and network-splitting functions Reviewed-by: Claus Hunsen <[email protected]>
To circumvent problems when updating the raw commits but not updating the cached list of artifacts, we disable the caching of artifacts for now. Signed-off-by: Claus Hunsen <[email protected]> Signed-off-by: Thomas Bock <[email protected]>
The ProjectData objects are handled as references in the NetworkBuilder objects, therefore, we need to clone the original data for the case of data cutting. Otherwise, we would just store the very same reference in two attributes. Signed-off-by: Claus Hunsen <[email protected]> Signed-off-by: Thomas Bock <[email protected]>
When constructing the sliding-window ranges in activity-based splitting of data objects, we cut the half of the wanted activity per range from the first and the very last range, then split the data. In the following, we need to set the splittable data properly again. With this patch, we fix the setting of the cut issue data. Signed-off-by: Claus Hunsen <[email protected]> Signed-off-by: Thomas Bock <[email protected]>
To conform more closely to the coding guidelines, we add several spaces before left parentheses (except for function calls) and left curly braces. A spacing-related line is added to the contribution guidelines to emphasize the point. Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
Small set of important fixes Reviewed-by: Thomas Bock <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
|
As we reviewed everything before, I will merge rightaway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.1.1
Changes in detail
v3.1...73e9caf
Changed/Improved
remove.isolatesparameter to some more network-splitting functions (011328e)Fixed
startandendis smaller thantime.period(Range construction fails when difference between start and end is smaller than time period #103, PR Some fixes to README, range construction, vertex attributes, and network-splitting functions #105, 975ae4d)