Small set of important fixes #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To circumvent problems when updating the raw commits but not updating the cached list of artifacts, we disable the caching of artifacts for now. Signed-off-by: Claus Hunsen <[email protected]> Signed-off-by: Thomas Bock <[email protected]>
The ProjectData objects are handled as references in the NetworkBuilder objects, therefore, we need to clone the original data for the case of data cutting. Otherwise, we would just store the very same reference in two attributes. Signed-off-by: Claus Hunsen <[email protected]> Signed-off-by: Thomas Bock <[email protected]>
When constructing the sliding-window ranges in activity-based splitting of data objects, we cut the half of the wanted activity per range from the first and the very last range, then split the data. In the following, we need to set the splittable data properly again. With this patch, we fix the setting of the cut issue data. Signed-off-by: Claus Hunsen <[email protected]> Signed-off-by: Thomas Bock <[email protected]>
To conform more closely to the coding guidelines, we add several spaces before left parentheses (except for function calls) and left curly braces. A spacing-related line is added to the contribution guidelines to emphasize the point. Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the patches in this PR, we fix some important bug in data objects (1bed431), network builders (2b327a9), and the splitting functionality (9860d7d).
Additionally, we enforce spacing before opening braces and parentheses as requested in the coding conventions (1ed449a).