Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make private attributes public in the metadata #1246

Merged
merged 9 commits into from
Feb 10, 2023
Merged

Make private attributes public in the metadata #1246

merged 9 commits into from
Feb 10, 2023

Conversation

fealho
Copy link
Member

@fealho fealho commented Feb 8, 2023

Resolve #1245.

@fealho fealho changed the base branch from master to V1.0.0.dev February 8, 2023 17:23
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023 •
edited
Loading

Codecov Report

Base: 95.74% // Head: 95.74% // No change to project coverage 👍

Coverage data is based on head (a754052) compared to base (d28ec14).
Patch coverage: 98.46% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff             @@
##           V1.0.0.dev    #1246   +/-   ##
===========================================
  Coverage       95.74%   95.74%           
===========================================
  Files              47       47           
  Lines            3669     3669           
===========================================
  Hits             3513     3513           
  Misses            156      156
Impacted Files Coverage Δ
sdv/multi_table/hma.py 82.79% <83.33%> (ø)
sdv/constraints/tabular.py 99.21% <93.75%> (ø)
sdv/constraints/base.py 97.89% <100.00%> (ø)
sdv/data_processing/data_processor.py 97.07% <100.00%> (ø)
sdv/metadata/multi_table.py 99.34% <100.00%> (ø)
sdv/metadata/single_table.py 99.20% <100.00%> (ø)
sdv/multi_table/base.py 99.42% <100.00%> (ø)
sdv/sequential/par.py 100.00% <100.00%> (ø)
sdv/single_table/base.py 100.00% <100.00%> (ø)
sdv/single_table/copulagan.py 96.07% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fealho fealho force-pushed the issue-1245-private-to-public-attributes branch from 5c69200 to a754052 Compare February 9, 2023 15:04
@fealho fealho marked this pull request as ready for review February 9, 2023 19:56
@fealho fealho requested a review from a team as a code owner February 9, 2023 19:56
@fealho fealho requested review from pvk-developer and amontanez24 and removed request for a team February 9, 2023 19:56
@fealho
Copy link
Member Author

fealho commented Feb 9, 2023

@pvk-developer @amontanez24 Each attribute was updated in its own commit, so it's easier to review.

amontanez24
amontanez24 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fealho fealho force-pushed the issue-1245-private-to-public-attributes branch from a754052 to 7ba8939 Compare February 10, 2023 19:51
@fealho fealho merged commit 61c5817 into V1.0.0.dev Feb 10, 2023
@fealho fealho deleted the issue-1245-private-to-public-attributes branch February 10, 2023 20:14
R-Palazzo pushed a commit that referenced this pull request Feb 13, 2023
@fealho @R-Palazzo
Make private attributes public in the metadata (#1246)
b95574a 
* _columns -> columns

* _primary_key -> primary_key

* _alternate_keys -> alternate_keys

* _sequence_key -> sequence_key

* _sequence_index -> sequence_index

* _tables -> tables

* _relationships -> relationships

* Fix keys

* Fix rebase
amontanez24 pushed a commit that referenced this pull request Feb 17, 2023
@fealho @amontanez24
Make private attributes public in the metadata (#1246)
1803a86 
* _columns -> columns

* _primary_key -> primary_key

* _alternate_keys -> alternate_keys

* _sequence_key -> sequence_key

* _sequence_index -> sequence_index

* _tables -> tables

* _relationships -> relationships

* Fix keys

* Fix rebase
amontanez24 pushed a commit that referenced this pull request Mar 23, 2023
@fealho @amontanez24
Make private attributes public in the metadata (#1246)
856a063 
* _columns -> columns

* _primary_key -> primary_key

* _alternate_keys -> alternate_keys

* _sequence_key -> sequence_key

* _sequence_index -> sequence_index

* _tables -> tables

* _relationships -> relationships

* Fix keys

* Fix rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make private attributes public in the metadata
4 participants
@fealho @codecov-commenter @amontanez24 @pvk-developer