Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make private attributes public in the metadata #1245

Closed
fealho opened this issue Feb 8, 2023 · 0 comments · Fixed by #1246
Closed

Make private attributes public in the metadata #1245

fealho opened this issue Feb 8, 2023 · 0 comments · Fixed by #1246
Assignees
@fealho
Labels
internal The issue doesn't change the API or functionality
Milestone
1.0.0

Comments

@fealho
Copy link
Member

fealho commented Feb 8, 2023

Version: SDV 1.0.0 (in progress)

Problem Description

Currently, metadata attributes are mostly private (underscore in front). Since there are no get methods for them they end up getting used in other files, which is not how private variables are supposed to be used.

Solution

In both single and multi table metadata files, change any private attributes which get used in other files to public.
@fealho fealho added internal The issue doesn't change the API or functionality new Automatic label applied to new issues labels Feb 8, 2023
@npatki npatki removed the new Automatic label applied to new issues label Feb 8, 2023
@npatki npatki added this to the 1.0.0 milestone Feb 8, 2023
@fealho fealho mentioned this issue Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fealho fealho

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Make private attributes public in the metadata sdv-dev/SDV
3 participants
@npatki @amontanez24 @fealho