feat(serialize): add SerializeRow impl for Box<T: SerializeRow>
#1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an implementation of the `SerializeRow` trait for `Box<T: SerializeRow>`. This allows boxed types to be serialized using the existing serialization framework. Included a unit test to verify the serialization of a boxed tuple. Signed-off-by: Daniel Boll <[email protected]>
|
|
wprzytula
approved these changes
Oct 26, 2024
|
Thank you for the contribution, @Daniel-Boll! |
Lorak-mmk
approved these changes
Oct 26, 2024
muzarski
approved these changes
Oct 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043
This PR implements
SerializeRowforBox<T: SerializeRow>, as suggested by@piodulin Missing SerializeRow impl for Box #1043. The aim is to address the user-reported use case where they need to perform batch queries with different length tuples (e.g., one insert into Table A and N inserts into Table B).I have also added a corresponding unit test (
test_row_serialization_with_boxed_tuple) to verify the behavior, comparing the serialization of a boxed tuple with that of a regular tuple.If there are any issues with this implementation, if I misunderstood the assignment, or if this feature would be better placed elsewhere, please let me know, and I'd be happy to make the necessary adjustments.
Looking forward to your feedback!
Best regards,
Daniel
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.