Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing SerializeRow impl for Box<dyn SerializeRow> #1043

Closed
wprzytula opened this issue Jul 29, 2024 · 1 comment · Fixed by #1105
Closed

Missing SerializeRow impl for Box<dyn SerializeRow> #1043

wprzytula opened this issue Jul 29, 2024 · 1 comment · Fixed by #1105
Labels
good first issue Good for newcomers

Comments

@wprzytula
Copy link
Collaborator

A user reported the following use case:

I'm trying to do a Batch query where there is one insert into table A and N inserts into table B. I'm having trouble figuring out how to create BatchValues for this. Since they are different length tuples I can't just construct a Vec of the tuples. Any suggestions on how to do this?

Implementing SerializeRow for Box<dyn SerializeRow> would allow passing Vec<Box<dyn SerializeRow>> as BatchValues.

@wprzytula wprzytula added the good first issue Good for newcomers label Jul 29, 2024
@piodul
Copy link
Collaborator

piodul commented Jul 29, 2024

There should just be an impl for Box<T: SerializeRow>. AFAIK &dyn Trait already implements Trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants