Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubectl logs retry in gke e2e script #1700

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix kubectl logs retry in gke e2e script #1700

merged 1 commit into from
Jan 24, 2024

Conversation

tnozicka
Copy link
Contributor

Description of your changes:
While we retry the e2e logs we need to make that call succeed or -e will fail the script

Which issue is resolved by this Pull Request:
Resolves #1698

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/flake Categorizes issue or PR as related to a flaky test. labels Jan 24, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@tnozicka
Copy link
Contributor Author

tnozicka commented Jan 24, 2024 •
edited
Loading

/hold
to see if it helps with #1664 that hits this fairly frequently

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@tnozicka
Copy link
Contributor Author

retry worked https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1664/pull-scylla-operator-master-e2e-gke-parallel/1750073678080512000#1:test-build-log.txt%3A1275
/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@tnozicka
Copy link
Contributor Author

#1694 (comment)
/retest

zimnx
zimnx approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit c6b88b4 into scylladb:master Jan 24, 2024
12 checks passed
@tnozicka tnozicka deleted the fix-e2e-logs branch January 24, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e tests are terminated prematurelly
2 participants
@tnozicka @zimnx