Inherit and customize ScyllaCluster labels and annotations #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnozicka
added
kind/feature
scylla-operator-bot
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scylla-operator-bot
bot
added
the
approved
tnozicka
force-pushed
the
metadata
branch
2 times, most recently
from
611f8e3 to
0283573
Compare
|
/test all |
tnozicka
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
tnozicka
requested review from
zimnx and
rzetelskik
and removed request for
zimnx
|
#1698 |
tnozicka
changed the title
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
tnozicka
force-pushed
the
metadata
branch
4 times, most recently
from
88cfb1d to
d50a5e6
Compare
tnozicka
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
zimnx
reviewed
Jan 29, 2024
|
Also, please add support for these fields in Helm chart template |
|
Thanks for updates. |
scylla-operator-bot
bot
added
the
lgtm
zimnx
added a commit
to zimnx/scylla-operator
that referenced
this pull request
Feb 5, 2024
Since scylladb#1664 metadata for data PVC template in rack StatefulSet was taken from ScyllaCluster metadata in case Statefulset was missing. If ScyllaCluster had any metadata set, Operator on next reconcilation, changed immutable PVC template because metadata were no longer rewritten from ScyllaCluster. To fix this case, Operator rewrites PVC template metadata from existing StatefulSet.
zimnx
added a commit
to zimnx/scylla-operator
that referenced
this pull request
Feb 6, 2024
Since scylladb#1664 metadata for data PVC template in rack StatefulSet was taken from ScyllaCluster metadata in case Statefulset was missing. If ScyllaCluster had any metadata set, Operator on next reconcilation, changed immutable PVC template because metadata were no longer rewritten from ScyllaCluster. To fix this case, Operator rewrites PVC template metadata from existing StatefulSet.
zimnx
added a commit
to zimnx/scylla-operator
that referenced
this pull request
Feb 6, 2024
Since scylladb#1664 metadata for data PVC template in rack StatefulSet was taken from ScyllaCluster metadata in case Statefulset was missing. If ScyllaCluster had any metadata set, Operator on next reconcilation, changed immutable PVC template because metadata were no longer rewritten from ScyllaCluster. To fix this case, Operator rewrites PVC template metadata from existing StatefulSet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This PR allows users to set metadata for several managed objects as described in SOEP-1665
Which issue is resolved by this Pull Request:
Resolves #1592 #1668