Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.11] Support update of StatefulSet selector #1660

Merged
merged 1 commit into from
Dec 22, 2023
Merged

[v1.11] Support update of StatefulSet selector #1660

merged 1 commit into from
Dec 22, 2023

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Dec 22, 2023

Backport of #1655

@zimnx
Support update of StatefulSet selector
32b1c43 
When Pods managed by existing StatefulSet matches new selector, StatefulSet
is orphan deleted and recreated.
@zimnx zimnx added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Dec 22, 2023
@zimnx zimnx requested a review from tnozicka December 22, 2023 15:33
@zimnx zimnx changed the title Support update of StatefulSet selector [v1.11] Support update of StatefulSet selector Dec 22, 2023
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2023
tnozicka
tnozicka approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

/hold
for #1655

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2023
@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx
Copy link
Collaborator Author

zimnx commented Dec 22, 2023

#1655 landed
/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2023
@zimnx
Copy link
Collaborator Author

zimnx commented Dec 22, 2023

#1525 (comment)

/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 6669866 into scylladb:v1.11 Dec 22, 2023
@zimnx zimnx deleted the mz/recreate-apply-sts-1.11 branch December 22, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimnx @tnozicka