Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support update of StatefulSet selector #1655

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Support update of StatefulSet selector #1655

merged 1 commit into from
Dec 22, 2023

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Dec 22, 2023 •
edited
Loading

When Pods managed by existing StatefulSet matches new selector, StatefulSet
is orphan deleted and recreated.

/cc @tnozicka

@zimnx zimnx added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Dec 22, 2023
@zimnx zimnx requested a review from tnozicka December 22, 2023 10:01
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2023
tnozicka
tnozicka reviewed Dec 22, 2023
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make a safety check that the new selector matches the old podLabels or this can go quite wrong at some point

tnozicka
tnozicka reviewed Dec 22, 2023
View reviewed changes
tnozicka
tnozicka reviewed Dec 22, 2023
View reviewed changes
@zimnx zimnx force-pushed the mz/recreate-apply-sts branch from ca05ee3 to b91e086 Compare December 22, 2023 12:05
@zimnx zimnx changed the title Support update of immutable fields in StatefulSet Support update of StatefulSet selector Dec 22, 2023
@zimnx
Copy link
Collaborator Author

zimnx commented Dec 22, 2023

I think we should make a safety check that the new selector matches the old podLabels or this can go quite wrong at some point

Good idea, done.

tnozicka
tnozicka reviewed Dec 22, 2023
View reviewed changes
@zimnx zimnx force-pushed the mz/recreate-apply-sts branch from b91e086 to 53a8d46 Compare December 22, 2023 12:29
tnozicka
tnozicka approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, rest lgtm
/approve

@zimnx zimnx force-pushed the mz/recreate-apply-sts branch 2 times, most recently from b23a900 to 63447f4 Compare December 22, 2023 13:44
@zimnx zimnx requested a review from tnozicka December 22, 2023 14:52
@zimnx
Support update of StatefulSet selector
b814650 
When Pods managed by existing StatefulSet matches new selector, StatefulSet
is orphan deleted and recreated.
@zimnx zimnx force-pushed the mz/recreate-apply-sts branch from 63447f4 to b814650 Compare December 22, 2023 15:09
@zimnx zimnx requested a review from tnozicka December 22, 2023 15:09
tnozicka
tnozicka approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks!

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx zimnx mentioned this pull request Dec 22, 2023
Merged
@scylla-operator-bot scylla-operator-bot bot merged commit 03d8d02 into scylladb:master Dec 22, 2023
@zimnx zimnx deleted the mz/recreate-apply-sts branch December 22, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimnx @tnozicka