#303 added equals method to currency object #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmillman
reviewed
Jun 6, 2024
| * @param {number|currency} foreign | ||
| * @returns {boolean} | ||
| */ | ||
| equals(foreign) { |
There was a problem hiding this comment.
Drive-by comment: "foreign" has a specific connotation in dealing with currencies (e.g. "foreign exchange rate") which falsely implies that this may deal with currency conversions. Perhaps another variable name like other would be less ambiguous?
zmillman
reviewed
Jun 6, 2024
| @@ -146,6 +146,21 @@ currency.prototype = { | |||
| return currency(intValue /= parse(number, _settings, false), _settings); | |||
| }, | |||
|
|
|||
| /** | |||
| * Compares value to another currency instance's value | |||
There was a problem hiding this comment.
How should this handle amounts of different currencies? (e.g. comparing dollars to euros?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple equals method to check for equality for either a number or another currency object. Added docs for new method.
#303