Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison of currency values #411

Open
shonubijerry opened this issue Nov 2, 2022 · 2 comments
Open

Comparison of currency values #411

shonubijerry opened this issue Nov 2, 2022 · 2 comments

Comments

@shonubijerry
Copy link

Implement comparison of currency <-> currency or currency <-> number

Operations
@joaoGabriel55
Copy link

I can take a look on that

@joaoGabriel55 joaoGabriel55 mentioned this issue Nov 10, 2022
Open
joaoGabriel55 added a commit to joaoGabriel55/currency.js that referenced this issue Dec 12, 2022
@joaoGabriel55
Merge branch 'main' into comparison-of-currency-values-scurker#411
bfc81c4
@jwarykowski
Copy link

jwarykowski commented Jan 16, 2023 •
edited
Loading

Would love this to be merged 🥇 Any reason why this can't go in @scurker? Would be great to get the other comparisons also. Just to note, should the comparison be on the value property or the true intValue? I can see this has been implemented on the value in @joaoGabriel55's PR. Perhaps we have an equals and strictEquals?

joaoGabriel55 added a commit to joaoGabriel55/currency.js that referenced this issue Sep 7, 2023
@joaoGabriel55
Merge branch 'main' into comparison-of-currency-values-scurker#411
093da8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwarykowski @joaoGabriel55 @shonubijerry