Verify new message type2 #1452
Verify new message type2 #1452
Conversation
cosmwasm/enclaves/shared/block-verifier/src/verify/registration.rs
Outdated
Show resolved
Hide resolved
| } | ||
| Err(e) => { | ||
| debug!("Error decoding registation protobuf: {}", e); | ||
| error!("Error decoding msg from block validator - 0xA0F2"); |
There was a problem hiding this comment.
What's the deal with this hex 0xA0F2?
There was a problem hiding this comment.
I kind of like adding random error codes - makes finding the exact error easier in a month or two when someone randomly pastes their error. Also we can one day create a codex of error codes & their meaning/more info, etc.
| use protobuf::Message; | ||
|
|
||
| pub fn verify_reg_msg(certificate: &[u8]) -> bool { | ||
| let mut verified_msgs = VERIFIED_MESSAGES.lock().unwrap(); |
There was a problem hiding this comment.
Not relevant specifically to this PR but just a thought, should we log a certain error in case this lock().unwrap() fails? Debugging this would be hell
There was a problem hiding this comment.
I actually think it would be kind of dramatic, as this would mean a failure in the lock or something? Not sure when this is even possible
There was a problem hiding this comment.
Yeah, it's going to give no details if it fails, but it should never fail.
No description provided.