Fix review comments

scrtlabs · May 29, 2023 · 39ba517 · 39ba517
1 parent d0c4ff8
commit 39ba517
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 12 deletions.
diff --git a/cosmwasm/enclaves/Cargo.lock b/cosmwasm/enclaves/Cargo.lock
diff --git a/cosmwasm/enclaves/execute/Cargo.toml b/cosmwasm/enclaves/execute/Cargo.toml
@@ -52,7 +52,6 @@ enclave_contract_engine = { path = "../shared/contract-engine" }
 enclave_crypto = { path = "../shared/crypto" }
 enclave_utils = { path = "../shared/utils" }
 enclave_cosmos_types = { path = "../shared/cosmos-types", optional = true }
-cosmos_proto = { path = "../shared/cosmos-proto" }
 
 serde = { git = "https://github.com/mesalock-linux/serde-sgx", features = [
   "derive"

diff --git a/cosmwasm/enclaves/shared/block-verifier/src/verify/registration.rs b/cosmwasm/enclaves/shared/block-verifier/src/verify/registration.rs
@@ -7,14 +7,6 @@ pub fn verify_reg_msg(certificate: &[u8]) -> bool {
     let next = verified_msgs.get_next();
 
     let result = if let Some(msg) = next {
-        // I assume @assaf will add the message type to the verified messages, so I'm going to leave this here for now
-        // without a check - it will fail in the parse either way
-
-        // if !check_message_is_reg(&msg) {
-        //     error!("Error failed to validate registration message - 0x7535");
-        //     false
-        // }
-
         match cosmos_proto::registration::v1beta1::msg::RaAuthenticate::parse_from_bytes(&msg) {
             Ok(ra_msg) => {
                 if ra_msg.certificate == certificate {

diff --git a/cosmwasm/enclaves/shared/block-verifier/src/wasm_messages.rs b/cosmwasm/enclaves/shared/block-verifier/src/wasm_messages.rs
@@ -152,8 +152,9 @@ pub mod tests {
 
         let tx = cosmos_proto::registration::v1beta1::msg::RaAuthenticate::parse_from_bytes(
             tx_bytes.as_slice(),
-        )
-        .unwrap();
+        );
+
+        assert!(tx.is_ok());
     }
 
     pub fn check_parse_reg_from_tx() {