Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3200): css fix to give round border of stages and right padding in WG container #1316

Merged
merged 4 commits into from
Dec 20, 2024
+4 −6
Merged

feat(3200): css fix to give round border of stages and right padding in WG container #1316

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14fde08
css fix to give round border of stages and some padding in wg
VonnyJap Dec 20, 2024
a3140ca
Update app/components/pipeline/workflow/styles.scss
VonnyJap Dec 20, 2024
dc9b69d
moved rx and ry to become svg attr
VonnyJap Dec 20, 2024
bb45c40
Merge branch 'master' into css-fix-graph
minghay Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/components/pipeline/workflow/graph/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,5 +99,10 @@
margin-top: 5px;
}
}

.stage-container {
rx: 5;
ry: 5;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rx and ry aren't valid CSS properties, they are for SVG elements. The proper fix is to actually remove the CSS here and in workflow-graph-d3/styles.scss and then modify utils/pipeline/graph/d3-graph-util.js so that the rx and ry attributes are set on the SVG rect element.

}
}
1 change: 1 addition & 0 deletions app/components/pipeline/workflow/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#workflow-display-container {
grid-area: workflow;
overflow: auto;
padding-right: max(1rem, 0.8vw);
VonnyJap marked this conversation as resolved.
Show resolved Hide resolved
$graph-controls-height: 2.5rem;

#workflow-display-controls {
Expand Down