feat(3200): css fix to give round border of stages and right padding in WG container #1316
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghay
requested changes
Dec 20, 2024
Comment on lines
102
to
106
|
|
||
| .stage-container { | ||
| rx: 5; | ||
| ry: 5; | ||
| } |
There was a problem hiding this comment.
rx and ry aren't valid CSS properties, they are for SVG elements. The proper fix is to actually remove the CSS here and in workflow-graph-d3/styles.scss and then modify utils/pipeline/graph/d3-graph-util.js so that the rx and ry attributes are set on the SVG rect element.
minghay
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The rectangle border around a stage in the new interface lacks a border radius, deviating from the current design. Additionally, the workflow graph container’s right side has no padding, making it visually unappealing.
Objective
Add border radius to the stage rectangles in the new interface and apply padding to the right side of the workflow graph container for improved visual consistency.
References
screwdriver-cd/screwdriver#3200
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.