fix(3247): virtual job icon is not used when the graph redraw (#1275)

screwdriver-cd · Dec 4, 2024 · 15f49be · 15f49be
1 parent ab42438
commit 15f49be
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/components/workflow-graph-d3/component.js b/app/components/workflow-graph-d3/component.js
@@ -205,7 +205,7 @@ export default Component.extend({
       if (n) {
         const txt = n.select('text');
 
-        txt.text(icon(node.status));
+        txt.text(icon(node.status, node.virtual));
         n.attr(
           'class',
           `graph-node${

diff --git a/app/utils/pipeline/graph/d3-graph-util.js b/app/utils/pipeline/graph/d3-graph-util.js
@@ -28,7 +28,7 @@ const STATUS_MAP = {
  * @return {String}        Unicode character that maps to an icon in screwdriver icon font
  */
 export function icon(status, isVirtual) {
-  if (isVirtual && (!status || ['SUCCESS', 'WARNING', 'CREATED'])) {
+  if (isVirtual) {
     return STATUS_MAP.VIRTUAL.icon;
   }