fix(3247): virtual job icon is not used when the graph redraw #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-oksaku
commented
Dec 3, 2024
| @@ -28,7 +28,7 @@ const STATUS_MAP = { | |||
| * @return {String} Unicode character that maps to an icon in screwdriver icon font | |||
| */ | |||
| export function icon(status, isVirtual) { | |||
| if (isVirtual && (!status || ['SUCCESS', 'WARNING', 'CREATED'])) { | |||
There was a problem hiding this comment.
Right hand side of this statement is always true.
I think that this might means ['SUCCESS', 'WARNING', 'CREATED'].includes(status).
But if use this statement then the icon will be able to change QUEUED to VIRTUAL.
In this case, we need to recalculate the icon size and its position when redrawing. This would be difficult.
This change explicitly allowed the virtual icon to have queued status (i.e. allow blue virtual icon).
yakanechi
approved these changes
Dec 3, 2024
yk634
approved these changes
Dec 3, 2024
tkyi
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Virtual job icon is not used after the workflow graph is redrew. (e.g. Uses stops the build)
Objective
Use virtual job icon correctly when the workflow graph is redrew.
References
Issue: screwdriver-cd/screwdriver#3247
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.