fix(3062): fix Dockerfile not to use npm start, and add shutdown method
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2024 14:34
yoshwata
approved these changes
Mar 21, 2024
yuichi10
reviewed
Mar 21, 2024
plugins/shutdown.js
Outdated
| /** | ||
| * Hapi plugin to handle serve graceful shutdown | ||
| * @method register | ||
| * @param {Hapi.Server} server |
There was a problem hiding this comment.
[nits]
Is lint working? It looks like there are many space between {Hapi.Server} and server
There was a problem hiding this comment.
Lint may not be working. I deleted the space.
yuichi10
approved these changes
Mar 21, 2024
tkyi
reviewed
Mar 21, 2024
Co-authored-by: Tiffany K <[email protected]>
DekusDenial
approved these changes
Mar 22, 2024
|
🎉 This PR is included in version 5.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Store server cannot receive
SIGTERM, and moreover the store even does not have the method of shutdown like api.See this issue for details:
screwdriver-cd/screwdriver#3062
Objective
node ./bin/serverdirectly, not vianpm startReferences
Issue: screwdriver-cd/screwdriver#3062
Docker and Node.js Best Practices:
https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#handling-kernel-signals
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.