Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracegul shutdown does not work when deleting pods of screwdriver component. #3062

Open
sakka2 opened this issue Mar 18, 2024 · 2 comments
Open

Comments

@sakka2
Copy link
Contributor

sakka2 commented Mar 18, 2024

What happened:
The process of server shutdown is implemented here, but it does not seem to perform actually during the server shutdown.
This may because that the application is not correctly catching the SIGTERM signal when the server is shutting down.

One possible reason is that the SIGTERM signals do not reach the actual node process if the application is executed in the order npm start -> node index.js. Especially, this problem seems to happen mainly with dockerized application.

Refer the link below:

What you expected to happen:
Node processes for each component properly catch SIGTERM signals and perform graceful shutdown.

How to reproduce it:
Delete or restart screwdriver.cd components on kubernetes.

@VonnyJap
Copy link
Member

@kumada626 - are you aware if the works to address this issue have been completed? If yes, then we should close the issue accordingly. Thank you!

@kumada626
Copy link
Contributor

@VonnyJap We think some additional modifications are needed to address this comment from PR.
So a little more we will continue to work on this Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants