Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3181): Skip execution of a virtual job when an event is started from that job #635

Merged

Conversation

sagar1312
Copy link
Member

@sagar1312 sagar1312 commented Dec 12, 2024

BREAKING CHANGE: Virtual job at the beginning of the event is no longer queued for execution. API changes are needed to process such build to mark its status as 'SUCCESS' and trigger its downstream jobs.

Context

When an event is started from the virtual job, build for such job is created and queued for execution immediately after creating the event.

Objective

For virtual jobs at the beginning in the workflow for an event,

  • set the status of the build to CREATED instead of QUEUED only if it doesn't have freeze windows

References

screwdriver-cd/screwdriver#3181

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@sagar1312 sagar1312 force-pushed the sagar1312-feat-3181-skip-virtual-job-as-event-origin branch from f634588 to 25379e1 Compare December 12, 2024 17:41
@sagar1312 sagar1312 changed the title fix(3181): Skip execution of a virtual job when an event is started from that job feat(3181): Skip execution of a virtual job when an event is started from that job Dec 12, 2024
lib/eventFactory.js Outdated Show resolved Hide resolved
@sagar1312 sagar1312 marked this pull request as ready for review December 12, 2024 22:11
@sagar1312 sagar1312 merged commit cea3593 into master Dec 12, 2024
2 checks passed
@sagar1312 sagar1312 deleted the sagar1312-feat-3181-skip-virtual-job-as-event-origin branch December 12, 2024 22:11
@sd-buildbot
Copy link

🎉 This PR is included in version 31.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants