Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screwdriver.cd/virtualJob seems to run the full job when triggered by hand #3181

Open
scr-oath opened this issue Aug 30, 2024 · 2 comments
Open

Comments

@scr-oath
Copy link

What happened:

Trigger via "restart from here" a job that is annotated with screwdriver.cd/virtualJob: true and watch it go through all steps such as checkout, cache pulling, etc.

What you expected to happen:

screwdriver.cd/virtualJob: true should do nothing no matter how it's triggered

How to reproduce it:

  • Create a job annotated with screwdriver.cd/virtualJob: true and trigger it by hand
  • Watch every step run.
@kumada626
Copy link
Contributor

I also found a case where a job annotated with screwdriver.cd/virtualJob: true executes all steps. If a job annotated with screwdriver.cd/virtualJob: true has ~commit or ~pr in its requires property and is triggered by scm webhook, the job will run every step.

@VonnyJap
Copy link
Member

As of now, this has been missed out for the implementation of virtual job and we are prioritizing this as the next improvement to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants