Skip to content

Commit

Permalink
udp: remove a needless instanceof Buffer check
Browse files Browse the repository at this point in the history
When a string is passed to udpsock.send, it is automatically
converted to a Buffer. In that case, it is no longer needed
to test whether or not the argument is a Buffer or not.

PR-URL: nodejs#4301
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
  • Loading branch information
ronkorving authored and Michael Scovetta committed Apr 2, 2016
1 parent dc02563 commit 8df5123
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lib/dgram.js
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,7 @@ Socket.prototype.send = function(buffer,

if (typeof buffer === 'string')
buffer = new Buffer(buffer);

if (!(buffer instanceof Buffer))
else if (!(buffer instanceof Buffer))
throw new TypeError('First argument must be a buffer or string');

offset = offset | 0;
Expand Down

0 comments on commit 8df5123

Please sign in to comment.