Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: revisit 30day cut-off for cleanup #35

Closed
bsipocz opened this issue Aug 15, 2023 · 4 comments
Closed

CI: revisit 30day cut-off for cleanup #35

bsipocz opened this issue Aug 15, 2023 · 4 comments
Labels
bug Something isn't working question Further information is requested

Comments

@bsipocz
Copy link
Member

bsipocz commented Aug 15, 2023

Now rereading the discussion in #4, consensus was more generous with the cutoff age of wheel removal, we should therefore change the currently implemented 30 to a much longer period.
@bsipocz bsipocz added the bug Something isn't working label Aug 15, 2023
@matthewfeickert
Copy link
Member

Agreed, I would give 3 to 6 months to be more generous with "slower" projects. But we could start with a lower bar and revisit if the use case ever comes up. — #4 (comment)

@tupui do you still feel this way? Or are you fine with 1 month as it is now?

upload-nightly-action/.github/workflows/remove-wheels.yml

Line 64 in 2b318b6

threshold_date="$(date +%F -d '30 days ago')"

@matthewfeickert matthewfeickert added the question Further information is requested label Aug 15, 2023
@bsipocz bsipocz mentioned this issue Aug 16, 2023
Merged
jarrodmillman pushed a commit to scientific-python/specs that referenced this issue Aug 17, 2023
@bsipocz
DOC: adding artefact retention policy to SPEC4 (#262)
18feb0c 
This is to address #261 
I'm on the opinion that it was a mistake to include so much
implementation detail in the SPEC itself, but as the other specifics of
https://anaconda.org/scientific-python-nightly-wheels are in the docs,
we should list these policies, too.


Also note, that we may eventually change the actual numbers, e.g.
scientific-python/upload-nightly-action#35


cc @mattip
@tupui
Copy link
Member

tupui commented Aug 25, 2023

Sorry for the delay, I was away 😃

I think the current config is ok for now. We can keep it that way until we have a request.

@matthewfeickert
Copy link
Member

Thanks @tupui. @bsipocz, are you good with closing this then?

@matthewfeickert
Copy link
Member

matthewfeickert commented Oct 5, 2023 •
edited
Loading

Closing as this hasn't had any new feedback since 2023-08-25 and there have been no complaints raised. This can be reopened if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewfeickert @bsipocz @tupui