Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing kerning para style #542

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Fixing kerning para style #542

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf2dc2a
Fixing kerning para style
Feb 8, 2024
90e340c
generated fixture
Feb 8, 2024
9856594
Update font_family.html
vikas-chaudhary-2802 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions examples/Kerning.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Shoes.app do

para "This text have kerning applied to it", kerning:10, size:18

para "This is normal text for reference", size:18

end
2 changes: 1 addition & 1 deletion lacci/lib/shoes/drawables/para.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class Shoes
class Para < Shoes::Drawable
include FontHelper
shoes_styles :text_items, :size, :family, :font_weight, :font, :font_variant, :emphasis
shoes_styles :text_items, :size, :family, :font_weight, :font, :font_variant, :emphasis, :kerning
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noahgibbs when we get these new excellent features; should we add them to manual.md you think?

Unless I'm being silly and kerning was an existing thing in manual.md 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kerning is in there already! We just only had it work recently :-)

There's a surprising amount of Shoes functionality we're still adding.

shoes_style(:stroke) { |val, _name| Shoes::Colors.to_rgb(val) }
shoes_style(:fill) { |val, _name| Shoes::Colors.to_rgb(val) }

Expand Down
Loading