Fixing kerning para style #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
approved these changes
Feb 8, 2024
|
Looks good! |
|
Looks like you'll need to generate HTML fixtures, since you added a new example. You should be able to do that by running "rake test:regenerate_html_fixtures" and adding the generated file to this PR. |
Schwad
reviewed
Feb 8, 2024
| @@ -3,7 +3,7 @@ | |||
| class Shoes | |||
| class Para < Shoes::Drawable | |||
| include FontHelper | |||
| shoes_styles :text_items, :size, :family, :font_weight, :font, :font_variant, :emphasis | |||
| shoes_styles :text_items, :size, :family, :font_weight, :font, :font_variant, :emphasis, :kerning | |||
There was a problem hiding this comment.
@noahgibbs when we get these new excellent features; should we add them to manual.md you think?
Unless I'm being silly and kerning was an existing thing in manual.md 😅
There was a problem hiding this comment.
Kerning is in there already! We just only had it work recently :-)
There's a surprising amount of Shoes functionality we're still adding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added the kerning para style --> #520
This PR introduces a new feature to the
Scarpelibrary - a kerning para style. Kerning is an important aspect of typography that adjusts the spacing between characters to achieve a visually pleasing result. This feature will allow users to apply kerning to their paragraphs, enhancing the visual appeal of their text.Image(if needed, helps for a faster review)
Checklist