ui/volume: rephrase the volume status from Available to Ready #2248

ChengYanJin · 2020-02-18T17:59:30Z

Component: ui, volume

Context:
The volume status available is confusing. For example, when the PV is bound, we displayed Available.

Summary:
Rephrase the volume status from Available to Ready

Acceptance criteria:

Closes: #2245

bert-e · 2020-02-18T17:59:33Z

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2020-02-18T17:59:41Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound into
development/2.4
w/2.5/bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound will be merged into development/2.5
w/2.6/bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound will be merged into development/2.6

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2020-02-18T17:59:43Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

slaperche-scality

I think you forgot to update the code for the hint popup in src/containers/NodeVolumes.js: it's still using STATUS_AVAILABLE instead of STATUS_READY

ui/src/services/NodeVolumesUtils.test.js

ui/src/services/NodeVolumesUtils.js

ui/src/constants.js

bert-e · 2020-02-18T19:10:10Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@slaperche-scality

bert-e · 2020-02-19T09:45:31Z

History mismatch

Merge commit #c77366ba6fd129d12b0e22b9502af4175e4dc12c on the integration branch
w/2.5/bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound is merging a branch which is neither the current
branch bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound nor the development branch
development/2.5.

It is likely due to a rebase of the branch bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

slaperche-scality

Works as expected

2 minor comments + 1 remark on a commit that wasn't correctly split.

ui/src/services/NodeVolumesUtils.js

ui/src/services/NodeVolumesUtils.test.js

ui/src/containers/NodeVolumes.js

The volume status available is confusing. For example, when the PV is bound, we displayed Available Refs: #2245

should return Ready as status when Ready condition is True Refs: #2245

update the indentation to meet the setting for vscode Refs: #2245

remove the single quote to meet the format of vscode Refs: #2245

- since we update the volume status from availble to ready, we want to update the cypress test to check if the volume status is ready Refs: #2245

ChengYanJin · 2020-02-21T08:05:10Z

/approve

bert-e · 2020-02-21T08:05:15Z

History mismatch

Merge commit #c77366ba6fd129d12b0e22b9502af4175e4dc12c on the integration branch
w/2.5/bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound is merging a branch which is neither the current
branch bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound nor the development branch
development/2.5.

It is likely due to a rebase of the branch bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

ChengYanJin · 2020-02-21T08:05:44Z

/reset

bert-e · 2020-02-21T08:05:51Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

bert-e · 2020-02-21T08:06:00Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound into
development/2.4
w/2.5/bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound will be merged into development/2.5
w/2.6/bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound will be merged into development/2.6

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2020-02-21T08:53:18Z

Build failed

The build for commit did not succeed in branch w/2.6/bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound.

The following options are set: approve

bert-e · 2020-02-21T09:55:49Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.4
✔️ development/2.5
✔️ development/2.6

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2020-02-21T22:44:01Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.4
✔️ development/2.5
✔️ development/2.6

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

Please check the status of the associated issue None.

Goodbye chengyanjin.

ChengYanJin requested a review from gdemonet February 18, 2020 17:59

ChengYanJin requested a review from a team as a code owner February 18, 2020 17:59

slaperche-scality suggested changes Feb 18, 2020

View reviewed changes

ui/src/services/NodeVolumesUtils.test.js Show resolved Hide resolved

ui/src/services/NodeVolumesUtils.js Show resolved Hide resolved

ui/src/services/NodeVolumesUtils.js Show resolved Hide resolved

ui/src/constants.js Show resolved Hide resolved

ChengYanJin force-pushed the bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound branch from 45e9933 to b4018f3 Compare February 19, 2020 09:45

ChengYanJin force-pushed the bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound branch from b4018f3 to 0195edd Compare February 19, 2020 14:28

slaperche-scality reviewed Feb 19, 2020

View reviewed changes

ui/src/services/NodeVolumesUtils.js Show resolved Hide resolved

ui/src/services/NodeVolumesUtils.test.js Outdated Show resolved Hide resolved

ui/src/containers/NodeVolumes.js Show resolved Hide resolved

ChengYanJin force-pushed the bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound branch 2 times, most recently from e438476 to 5489868 Compare February 20, 2020 09:02

ChengYanJin added 4 commits February 20, 2020 12:13

ui/volume: rephrase the volume status from Available to Ready

8f428ff

The volume status available is confusing. For example, when the PV is bound, we displayed Available Refs: #2245

ui/test: update the test for volume

f46a0a1

should return Ready as status when Ready condition is True Refs: #2245

ui/volume: reformat the indentation

df1de17

update the indentation to meet the setting for vscode Refs: #2245

ui/test: formatting

bb95149

remove the single quote to meet the format of vscode Refs: #2245

ChengYanJin force-pushed the bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound branch from 5489868 to bb95149 Compare February 20, 2020 11:20

slaperche-scality previously approved these changes Feb 20, 2020

View reviewed changes

ui/cypresstest: update the create volume cypress test

211ebda

- since we update the volume status from availble to ready, we want to update the cypress test to check if the volume status is ready Refs: #2245

ChengYanJin dismissed slaperche-scality’s stale review via 211ebda February 20, 2020 17:14

slaperche-scality approved these changes Feb 21, 2020

View reviewed changes

bert-e merged commit 3dab6a4 into development/2.4 Feb 21, 2020

bert-e deleted the bugfix/2245-rephrase-the-volume-status-when-the-pv-is-bound branch February 21, 2020 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ui/volume: rephrase the volume status from Available to Ready #2248

ui/volume: rephrase the volume status from Available to Ready #2248

ChengYanJin commented Feb 18, 2020

bert-e commented Feb 18, 2020

bert-e commented Feb 18, 2020

bert-e commented Feb 18, 2020

slaperche-scality left a comment

bert-e commented Feb 18, 2020

bert-e commented Feb 19, 2020

slaperche-scality left a comment

ChengYanJin commented Feb 21, 2020

bert-e commented Feb 21, 2020

ChengYanJin commented Feb 21, 2020

bert-e commented Feb 21, 2020

bert-e commented Feb 21, 2020

bert-e commented Feb 21, 2020

bert-e commented Feb 21, 2020

bert-e commented Feb 21, 2020

ui/volume: rephrase the volume status from Available to Ready #2248

ui/volume: rephrase the volume status from Available to Ready #2248

Conversation

ChengYanJin commented Feb 18, 2020

bert-e commented Feb 18, 2020

Hello chengyanjin,

bert-e commented Feb 18, 2020

Integration data created

bert-e commented Feb 18, 2020

Waiting for approval

slaperche-scality left a comment

Choose a reason for hiding this comment

bert-e commented Feb 18, 2020

Waiting for approval

bert-e commented Feb 19, 2020

History mismatch

slaperche-scality left a comment

Choose a reason for hiding this comment

ChengYanJin commented Feb 21, 2020

bert-e commented Feb 21, 2020

History mismatch

ChengYanJin commented Feb 21, 2020

bert-e commented Feb 21, 2020

Reset complete

bert-e commented Feb 21, 2020

Integration data created

bert-e commented Feb 21, 2020

Build failed

bert-e commented Feb 21, 2020

In the queue

bert-e commented Feb 21, 2020