New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rephrase the volume status #2245

Closed

ChengYanJin opened this issue Feb 14, 2020 · 1 comment

Assignees

Labels

complexity:easy kind:bug topic:storage topic:ui

Contributor

ChengYanJin commented Feb 14, 2020 •

edited

Loading

Component: ui, volume

What happened:
When the pv is bound, we display the Available instead of Ready for volume's status which is confusing.

What was expected:
Rephrase the volume status from Available to Ready

Steps to reproduce

Resolution proposal (optional):
will fix it in dev/2.4 branch

The text was updated successfully, but these errors were encountered:

ChengYanJin added kind:bug topic:storage topic:ui complexity:easy labels

ChengYanJin self-assigned this

ChengYanJin changed the title ~~rephrase the volume status when the pv is bound~~ rephrase the volume status

ChengYanJin added a commit that referenced this issue


          ui/volume: rephrase the volume status from availble to ready

c77366b

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: update the test for volume status

45e9933

- should return Ready when Ready condition is True
Refs: #2245

ChengYanJin mentioned this issue

ui/volume: rephrase the volume status from Available to Ready #2248

Merged

ChengYanJin added a commit that referenced this issue


          ui/volume: rephrase the volume status from Available to Reday

9deb8a6

The volume status available is confusing. For example, when the PV is bound, we displayed Available

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: update the test for volume

958f6ad

should return Ready as status when Ready condition is True

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/volume: reformat the indentation

42def8b

update the indentation to meet the setting for vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: formatting

b4018f3

remove the single quote to meet the format of vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: update the test for volume

a1ca49a

should return Ready as status when Ready condition is True

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/volume: reformat the indentation

a6b0981

update the indentation to meet the setting for vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: formatting

0195edd

remove the single quote to meet the format of vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/volume: rephrase the volume status from Available to Reday

8289c56

The volume status available is confusing. For example, when the PV is bound, we displayed Available

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: update the test for volume

should return Ready as status when Ready condition is True

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/volume: reformat the indentation

3f4325c

update the indentation to meet the setting for vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: formatting

e438476

remove the single quote to meet the format of vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: update the test for volume

ce5e706

should return Ready as status when Ready condition is True

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/volume: reformat the indentation

744c394

update the indentation to meet the setting for vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: formatting

remove the single quote to meet the format of vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/volume: rephrase the volume status from Available to Ready

8f428ff

The volume status available is confusing. For example, when the PV is bound, we displayed Available

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: update the test for volume

f46a0a1

should return Ready as status when Ready condition is True

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/volume: reformat the indentation

df1de17

update the indentation to meet the setting for vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/test: formatting

bb95149

remove the single quote to meet the format of vscode

Refs: #2245

ChengYanJin added a commit that referenced this issue


          ui/cypresstest: update the create volume cypress test

211ebda

- since we update the volume status from availble to ready,
  we want to update the cypress test to check if the volume status is ready

Refs: #2245

Contributor Author

ChengYanJin commented Mar 27, 2020

Already merged in 2.4/2.5/2.6.

ChengYanJin closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment