UI: Dex integration #2042

carlito-scality · 2019-11-13T17:28:47Z

Component: UI

Context:

Integrate Dex login using redux-oidc library

Summary:

Acceptance criteria:

The MetalK8s UI should directly use dex to authenticate a user using OAuth2 flow.
Once logged in, the reste should works like before without regressions

Closes: #2015

bert-e · 2019-11-13T17:28:49Z

Hello carlito-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2019-11-13T17:28:53Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2019-11-18T10:55:25Z

Conflict

There is a conflict between your branch feature/dex-integration-in-ui and the
destination branch development/2.4.

Please resolve the conflict on the feature branch (feature/dex-integration-in-ui).

 $ git fetch
 $ git checkout origin/feature/dex-integration-in-ui
 $ git merge origin/development/2.4
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:feature/dex-integration-in-ui

bert-e · 2019-11-20T08:22:44Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

gdemonet · 2019-11-21T22:49:28Z

/after_pull_request=2063

bert-e · 2019-11-21T22:49:31Z

Waiting for other pull request(s)

The current pull request is locked by the after_pull_request option.

In order for me to merge this pull request, run the following actions first:

➡️ Merge the OPEN pull request:

pull request Upgrade Kubernetes to 1.16.2 #2063

Alternatively, delete all the after_pull_request comments from this pull request.

The following options are set: after_pull_request

gdemonet · 2019-11-21T22:50:05Z

@carlito-scality you'll need to rebase on development/2.5 when #2063 gets merged.

gdemonet · 2019-11-21T22:52:40Z

/after_pull_request=2025

bert-e · 2019-11-21T22:52:43Z

Waiting for other pull request(s)

The current pull request is locked by the after_pull_request option.

In order for me to merge this pull request, run the following actions first:

➡️ Merge the OPEN pull requests:

pull request Deploy dex in metalk8s from helm charts #2025
pull request Upgrade Kubernetes to 1.16.2 #2063

Alternatively, delete all the after_pull_request comments from this pull request.

The following options are set: after_pull_request

bert-e · 2019-11-25T08:37:13Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: after_pull_request

ChengYanJin

LGTM! Great job!!!
We will need to handle share user data between tabs in order to eliminate unnecessary authentication.

- re-implement the login workflow using redux-oidc library - update the way to authenticate to Salt - remove old Login page and image

- catch the redux-oidc USER_FOUND action, to update ApiK8s services and authenticate to salt - add isUserLoaded state to check if the user is loaded

…irect urls - url_oidc_provider allow to fetch /oidc/.well-known/openid-configuration file - url_redirect should contain full URL since it should be regirstered as it is in the DEX config and it is used for redirection once the login in DEX login form is successful. Ref: #2015

- After the login in Dex Form is successful, we go back to the CallbackPage containing a Loader with the text Ref: #2015

- update cypress.json with new default login - add return null to PrivateRoute since it should always return something. Otherswise, we got an JS error. Ref: #2015

Ref: #2015

- Display only username instead of username + email - update cypress tests Ref: #2015

- it is introduced during last rebasing

-We add redux-oidc for dex login which increase the bundle size.

When we try to retrieve informations from the mine from salt-master we cannot use module `mine.get` we need to use `saltutil.runner` with `mine.get`, this approach works for salt-master but not for salt-minion not on the same machine as the salt-master

TeddyAndrieux

backend part LGTM

carlito-scality · 2019-12-06T09:39:17Z

/approve

bert-e · 2019-12-06T09:39:27Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.5

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, after_pull_request

bert-e · 2019-12-06T18:39:51Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.5

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4

Please check the status of the associated issue None.

Goodbye carlito-scality.

carlito-scality added moonshot topic:ui UI-related issues complexity:hard Something that may require up to a week to fix labels Nov 13, 2019

carlito-scality force-pushed the feature/dex-integration-in-ui branch 2 times, most recently from e72662b to 0adb9da Compare November 18, 2019 10:55

carlito-scality force-pushed the feature/dex-integration-in-ui branch 4 times, most recently from 5d50b5a to 2fbcb2b Compare November 20, 2019 08:22

carlito-scality force-pushed the feature/dex-integration-in-ui branch 2 times, most recently from 2e37316 to 1b61997 Compare November 21, 2019 15:23

gdemonet changed the base branch from development/2.4 to development/2.5 November 21, 2019 22:49

carlito-scality force-pushed the feature/dex-integration-in-ui branch from 1b61997 to 31ea676 Compare November 25, 2019 08:37

carlito-scality force-pushed the feature/dex-integration-in-ui branch from 31ea676 to d90a339 Compare November 25, 2019 10:17

carlito-scality marked this pull request as ready for review November 25, 2019 17:02

carlito-scality requested a review from a team as a code owner November 25, 2019 17:02

carlito-scality force-pushed the feature/dex-integration-in-ui branch from 83aad41 to e7356df Compare November 26, 2019 10:12

ChengYanJin force-pushed the feature/dex-integration-in-ui branch 2 times, most recently from a9e7b6f to 3c0c96e Compare November 26, 2019 15:12

carlito-scality force-pushed the feature/dex-integration-in-ui branch from 3c0c96e to f3654d2 Compare November 26, 2019 16:01

ChengYanJin previously approved these changes Nov 27, 2019

View reviewed changes

carlito-scality dismissed ChengYanJin’s stale review via 9c58233 November 27, 2019 10:44

TeddyAndrieux mentioned this pull request Nov 27, 2019

salt/auth: Add groups support for bearer auth #2068

Merged

carlito-scality force-pushed the feature/dex-integration-in-ui branch from 765b2a9 to e0f2eab Compare November 29, 2019 09:20

bert-e mentioned this pull request Nov 29, 2019

Improvement/2078 store user credentials in localstorage #2088

Merged

ChengYanJin previously approved these changes Nov 29, 2019

View reviewed changes

carlito-scality dismissed ChengYanJin’s stale review via d288e24 December 2, 2019 08:44

carlito-scality force-pushed the feature/dex-integration-in-ui branch 2 times, most recently from d288e24 to 81ef5b9 Compare December 3, 2019 10:19

TeddyAndrieux force-pushed the feature/dex-integration-in-ui branch 2 times, most recently from e43f24b to f250e1e Compare December 4, 2019 21:40

carlito-scality and others added 11 commits December 5, 2019 17:48

UI: integrate Dex using redux-oidc

75c78a2

- re-implement the login workflow using redux-oidc library - update the way to authenticate to Salt - remove old Login page and image

UI: refresh page management

44825d3

- catch the redux-oidc USER_FOUND action, to update ApiK8s services and authenticate to salt - add isUserLoaded state to check if the user is loaded

update local config.json with url_oidc_provider and url_redirect

2e5703c

UI: improve the Login Redirecting page

70896f7

- After the login in Dex Form is successful, we go back to the CallbackPage containing a Loader with the text Ref: #2015

UI: update cypress tests to support DEX

df9e905

- update cypress.json with new default login - add return null to PrivateRoute since it should always return something. Otherswise, we got an JS error. Ref: #2015

UI: update tests relative to login

c48d578

Ref: #2015

UI: Display only username once logged in

c4b2e64

- Display only username instead of username + email - update cypress tests Ref: #2015

UI: remove useless code

aa76f1a

- it is introduced during last rebasing

UI: increase the limit the maxAssetSize

d19fea7

-We add redux-oidc for dex login which increase the bundle size.

carlito-scality force-pushed the feature/dex-integration-in-ui branch from f250e1e to 1364f5f Compare December 5, 2019 17:40

TeddyAndrieux approved these changes Dec 6, 2019

View reviewed changes

bert-e merged commit 1364f5f into development/2.5 Dec 6, 2019

bert-e deleted the feature/dex-integration-in-ui branch December 6, 2019 18:39

gdemonet mentioned this pull request Dec 10, 2019

Configure the UI to require authentication through Dex #2015

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI: Dex integration #2042

UI: Dex integration #2042

carlito-scality commented Nov 13, 2019 •

edited

Loading

bert-e commented Nov 13, 2019

bert-e commented Nov 13, 2019

bert-e commented Nov 18, 2019

bert-e commented Nov 20, 2019

gdemonet commented Nov 21, 2019

bert-e commented Nov 21, 2019

gdemonet commented Nov 21, 2019

gdemonet commented Nov 21, 2019

bert-e commented Nov 21, 2019

bert-e commented Nov 25, 2019

ChengYanJin left a comment

TeddyAndrieux left a comment

carlito-scality commented Dec 6, 2019

bert-e commented Dec 6, 2019

bert-e commented Dec 6, 2019

UI: Dex integration #2042

UI: Dex integration #2042

Conversation

carlito-scality commented Nov 13, 2019 • edited Loading

bert-e commented Nov 13, 2019

Hello carlito-scality,

bert-e commented Nov 13, 2019

Waiting for approval

bert-e commented Nov 18, 2019

Conflict

bert-e commented Nov 20, 2019

Waiting for approval

gdemonet commented Nov 21, 2019

bert-e commented Nov 21, 2019

Waiting for other pull request(s)

gdemonet commented Nov 21, 2019

gdemonet commented Nov 21, 2019

bert-e commented Nov 21, 2019

Waiting for other pull request(s)

bert-e commented Nov 25, 2019

Waiting for approval

ChengYanJin left a comment

Choose a reason for hiding this comment

TeddyAndrieux left a comment

Choose a reason for hiding this comment

carlito-scality commented Dec 6, 2019

bert-e commented Dec 6, 2019

In the queue

bert-e commented Dec 6, 2019

carlito-scality commented Nov 13, 2019 •

edited

Loading